fix minor linting issues in tests#105
Open
thaJeztah wants to merge 1 commit intoopencontainers:masterfrom
Open
fix minor linting issues in tests#105thaJeztah wants to merge 1 commit intoopencontainers:masterfrom
thaJeztah wants to merge 1 commit intoopencontainers:masterfrom
Conversation
Just to please the linters;
verifiers_test.go:28:11: Error return value of `rand.Read` is not checked (errcheck)
rand.Read(p)
^
verifiers_test.go:33:9: Error return value of `io.Copy` is not checked (errcheck)
io.Copy(verifier, bytes.NewReader(p))
^
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
requested review from
AkihiroSuda,
dmcgowan,
stevvooe and
vbatts
as code owners
Member
Author
|
I'll have a look at actually adding golangci-lint to this repo as well |
AkihiroSuda
approved these changes
Jan 16, 2025
Member
Author
|
ping @opencontainers/go-digest-maintainers PTAL |
sudo-bmitch
approved these changes
Apr 23, 2026
tianon
approved these changes
Apr 23, 2026
Member
tianon
left a comment
tianon
left a comment
There was a problem hiding this comment.
(looks like that team alias needs an update - it has more members than the maintainers file does)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just to please the linters;